Only check if model supports mass balance checks if mass balance feature is enabled #916
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently,The new behavior checks if a bmi model supports mass balance checks only if the mass balance checking feature is enabled.ngenwill throw an exception if any model in the model stack does not support mass balance checks regardless of if mass balance checking is configured. The fixedRevisiting this. The exception I was getting from
ngenwas not related to the mass balance checker.I do think we should still change the behavior to only check if a model is capable of mass balance checks if configured. Otherwise,
stderris spammed with messages like the following for each divide w/ a model that does not support mass balance checks: