Control verbosity of debug output via build config - #58
Merged
robertbartel merged 7 commits intoAug 4, 2026
Merged
Conversation
robertbartel
force-pushed
the
f/build_improvements/control_verbosity
branch
5 times, most recently
from
February 17, 2026 16:12
2744a24 to
61f3c89
Compare
robertbartel
force-pushed
the
f/build_improvements/control_verbosity
branch
from
March 5, 2026 15:18
ec52aa8 to
65f508e
Compare
robertbartel
marked this pull request as ready for review
August 4, 2026 19:27
Setting macro TOPMODEL_DEBUG via new CMake DEBUG_VERBOSITY variable, rather than hard-coding directly within topmodel.h.
Applying verbosity controls via TOPMODEL_DEBUG macro to a statment in topmodel.c hat brings the "subcat" as read from the config file.
PhilMiller
reviewed
Aug 4, 2026
| # Misc # | ||
| ######## | ||
| make_and_run_bmi.sh | ||
| .idea |
Contributor
There was a problem hiding this comment.
Put this sort of thing in your globally configured Git ignore file: https://stackoverflow.com/a/22885996/90002 - e.g. ~/.config/git/ignore, rather than something repo-specific, since the use of IDEA isn't repo-specific
robertbartel
force-pushed
the
f/build_improvements/control_verbosity
branch
from
August 4, 2026 19:33
65f508e to
770f29d
Compare
PhilMiller
reviewed
Aug 4, 2026
PhilMiller
reviewed
Aug 4, 2026
| # Use 1 by default when build type is "Debug" | ||
| if (NOT DEFINED DEBUG_VERBOSITY AND "${CMAKE_BUILD_TYPE}" STREQUAL "Debug") | ||
| set(DEBUG_VERBOSITY 1) | ||
| # Use 0 by default for any build types other than "Debug" |
Contributor
There was a problem hiding this comment.
The comment positioning/formatting here is confusing, since it appears to be inside the preceding block, rather than annotating the following
Contributor
Author
There was a problem hiding this comment.
Agreed; not sure why I did that. Fixed.
PhilMiller
previously approved these changes
Aug 4, 2026
PhilMiller
left a comment
PhilMiller
left a comment
Contributor
There was a problem hiding this comment.
Minor concerns, but this does what it needs to.
Rewording slightly per suggestion. Co-authored-by: Phil Miller - NOAA <pmiller@lynker.com>
PhilMiller
approved these changes
Aug 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note this depends on #57 and should remain in draft status until that PR is finished.
Control verbosity of debug output using CMake variable
DEBUG_VERBOSITY, rather than hard coding.Removals
TOPMODEL_DEBUGChanges
DEBUG_VERBOSITYvariable and use that to set theTOPMODEL_DEBUGmacro via compile definition.Checklist
Testing checklist
Target Environment support
Accessibility
Other