Add multipath-aware RIST metrics - #230
Open
romestylez wants to merge 1 commit into
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changed
The current RIST implementation adds all peer bitrates together and averages their RTT. This does not work very well for bonded/multipath RIST because a slow path carrying almost no traffic can still trigger the low scene.
This PR adds an optional
"multipath": truesetting. When enabled, NOALBS uses:Existing RIST configs keep the old behavior unless the option is enabled.
Tests
Added deterministic tests for legacy behavior, multipath stats, dead peers and the normal/low/offline scene decisions.
cargo test: 32 passed, 0 failed.I'm not much of a PR novelist, so this description got a little AI polish. The code is still the important bit 😄