Open
Conversation
gaeulzzang
requested review from
jihyunniiii,
kez-lab,
leeseokchan00 and
yskim6772
1 task
yskim6772
approved these changes
Jun 9, 2024
Comment on lines
+31
to
+33
| val userService by lazy { ApiFactory.create<UserService>(AUTH_BASE_URL) } | ||
| val authService by lazy { ApiFactory.create<AuthService>(AUTH_BASE_URL) } | ||
| val friendService by lazy { ApiFactory.create<FriendService>(FRIEND_BASE_URL) } |
|
|
||
| } | ||
|
|
||
| const val PAGE = 2 No newline at end of file |
| @@ -113,7 +112,7 @@ class MainActivity : ComponentActivity() { | |||
| } | |||
|
|
|||
| 1 -> { | |||
Member
There was a problem hiding this comment.
여기도 selectedItem들도 상수화해주면 좋을 것 같아요 ! (0, 1, 2 한번에 코멘트 달고 싶었는데 왜 한줄밖에 클릭이 안 될까요 .. 🤣😂)
Comment on lines
+121
to
+123
| val intent = Intent(context, LoginActivity::class.java) | ||
| intent.flags = Intent.FLAG_ACTIVITY_CLEAR_TASK or Intent.FLAG_ACTIVITY_NEW_TASK | ||
| context.startActivity(intent) |
jihyunniiii
reviewed
Jun 9, 2024
Comment on lines
+16
to
+18
| override suspend fun login(request: RequestLoginDto): Response<ResponseLoginDto> { | ||
| return authService.login(request) | ||
| } |
There was a problem hiding this comment.
Suggested change
| override suspend fun login(request: RequestLoginDto): Response<ResponseLoginDto> { | |
| return authService.login(request) | |
| } | |
| override suspend fun login(request: RequestLoginDto): Response<ResponseLoginDto> = authService.login(request) |
이런 식으로 작성할 수도 있습니당
leeseokchan00
approved these changes
Jun 9, 2024
| import androidx.lifecycle.ViewModel | ||
| import androidx.lifecycle.ViewModelProvider | ||
|
|
||
| class BaseViewModelFactory<T>(private val creator: () -> T) : ViewModelProvider.Factory { |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue 🛠
Work Description ✏️
Screenshot 📸
Screen_recording_20240605_161814.mp4
To Reviewers 📢
작업하면서 커밋 자주 하는걸 깜빡했습니다...