Feat/week xml 07#14
Open
hyoeunjoo wants to merge 17 commits into
Open
Conversation
OliviaYJH
approved these changes
Jun 9, 2024
| ): Call<ResponseSignUpDto> | ||
| ): Response<Unit> | ||
|
|
||
| @POST("member/login") |
Member
There was a problem hiding this comment.
요기만 다른 서버 통신과 응답 데이터 형식이 다르네요! 혹시 이유가 있을까요?
| import com.sopt.now.data.AuthRepoImpl | ||
| import com.sopt.now.data.api.ServicePool | ||
|
|
||
| class LoginViewModelFactory : ViewModelProvider.Factory { |
chanubc
reviewed
Jun 9, 2024
Member
chanubc
left a comment
chanubc
left a comment
There was a problem hiding this comment.
일단 저번주차와 동일해보여서
저번주차가 머지하고 다시 리뷰해드릴게요!!
한 학기동안 정말 고생많았어요!
고마워요ㅠㅠ
Comment on lines
+6
to
+9
| interface AuthRepository { | ||
| suspend fun logIn(authData: AuthEntity): Result<Response<Unit>> | ||
| suspend fun signUp(authData: AuthEntity): Result<Response<Unit>> | ||
| } No newline at end of file |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
📌𝘐𝘴𝘴𝘶𝘦𝘴
📎𝘞𝘰𝘳𝘬 𝘋𝘦𝘴𝘤𝘳𝘪𝘱𝘵𝘪𝘰𝘯
📷𝘚𝘤𝘳𝘦𝘦𝘯𝘴𝘩𝘰𝘵
화면은 이전과 동일하게 작동됩니다.
💬𝘛𝘰 𝘙𝘦𝘷𝘪𝘦𝘸𝘦𝘳𝘴
6주차 코리를 제대로 반영하지 못했습니다..! 시험 끝나고 얼른 반영하겠습니다
부족한 부분들은 언제든지 말씀해주세요!