Add a multilayer reading option for AOI#507
Open
CharlesAuthier wants to merge 2 commits intoNRCan:developfrom
Open
Add a multilayer reading option for AOI#507CharlesAuthier wants to merge 2 commits intoNRCan:developfrom
CharlesAuthier wants to merge 2 commits intoNRCan:developfrom
Conversation
CharlesAuthier
requested review from
mpelchat04,
ms888ekb,
remtav,
valhassan and
veurman3
ms888ekb
reviewed
Apr 4, 2023
|
|
||
|
|
||
| def check_gdf_load(gdf): | ||
| def check_gdf_load(gdf: Union[str, Path, gpd.GeoDataFrame]) -> gpd.GeoDataFrame: |
Collaborator
There was a problem hiding this comment.
good job Charles! I like how you improved this part.
ms888ekb
reviewed
Apr 4, 2023
| [multi_layers, geopkg], | ||
| ignore_index=True | ||
| ) | ||
| return multi_layers |
Collaborator
There was a problem hiding this comment.
In general, I understand why it makes sense to know if the label gpkg is a multi-layer or not. But do we have label gpkg in practice? I thought we always have a single-layer single-class gpkg for training? If this is not true, then I need to adjust my tiling script too.
Collaborator
Author
There was a problem hiding this comment.
We mustly use single-layer single-class, but we want to also support multi-classes and Pierre told me that the GPKG will be multi layer.
Collaborator
There was a problem hiding this comment.
@CharlesAuthier let's discuss it altogether with Mathieu next week because it will require many potential adjustments to the code.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add the option to read a multilayers GPKG when is read by the AOI function.
Plus tests for the entire
check_gdf_loadfunction.