DRAFT: Refactor utils and tools, add first party source for ruff and set initial environmenet#590
Closed
LucaRom wants to merge 6 commits intolightning_refactorfrom
Closed
DRAFT: Refactor utils and tools, add first party source for ruff and set initial environmenet#590LucaRom wants to merge 6 commits intolightning_refactorfrom
LucaRom wants to merge 6 commits intolightning_refactorfrom
Conversation
Removed tools/utils.py and added a dedicated utils folder containing models.py, rasters.py and tensors.py Existing utils functions were splitted between models.py and tensors.py New generic functions for rasters were added to rasters.py Updated the imports in the tasks_with_models files to reflect those changes
…rated in the autoformatting
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Main update is a suggested refactoring of the tools folder and the utils.py file.
The vision is to promote modularity and future growth of GDL while avoiding a clogged utils.py file as we add different use cases and projects.
Distinction between tools and utils:
Refactoring details :
Other updates:
Smaller commits are also included in this PR: