Draft
Conversation
Mb/decomposition updates
…e step) index. See PSI issue #1505
Contributor
|
Performance Results
|
GabrielKS
reviewed
Jan 14, 2026
Member
There was a problem hiding this comment.
I recommend using the functionality in src/utils/indexing.jl, such as assign_maybe_broadcast!, rather than manually branching on number of dimensions all the time. That is how I handle all the 3D parameters stuff internally and it leads to lots less duplicate code and doesn't seem to be horrible performance-wise. My draft PR #1518 is an example of how to do that with results — that should probably be subsumed within this.
Fix straggling 3D results issue
Member
|
This PR needs testing with the IEC curves. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.