Skip to content

Rjf/dependencies bump #303

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Apr 17, 2025
Merged

Rjf/dependencies bump #303

merged 5 commits into from
Apr 17, 2025

Conversation

robfitzgerald
Copy link
Collaborator

this PR bumps all dependencies to latest except ninterp, which we should reboot discussions with @kylecarow about.

a few api changes to dependencies:

bincode (major version)
  • changes to signatures
  • we are using a "legacy" config for bincode 1.0 compatibility. when RouteE Powertrain models move to bincode 2.0.0 we should modify this
  • we should even parameterize this so that we support v1 and v2 bincode files
wkb

complete rewrite of the wkb library between 0.7 and 0.8 has new api and hopefully is more reliable (it has produced invalid WKBs in bambam)

Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 8 out of 8 changed files in this pull request and generated no comments.

Comments suppressed due to low confidence (1)

rust/routee-compass/src/plugin/output/default/traversal/traversal_output_format.rs:112

  • Converting raw WKB binary data directly to a UTF8 string may result in decoding errors since WKB is not guaranteed to be valid UTF8. Consider using hex encoding to produce a consistent, human-readable string representation.
let out_string = String::from_utf8(out_bytes).map_err(|e| {

@robfitzgerald robfitzgerald merged commit e650c08 into main Apr 17, 2025
5 checks passed
@robfitzgerald robfitzgerald deleted the rjf/dependencies-bump branch April 17, 2025 19:59
@kylecarow
Copy link
Collaborator

Regarding a ninterp version bump, see new PR #308

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants