-
Notifications
You must be signed in to change notification settings - Fork 114
Ssc 195 day of week improvements #1352
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…y_of_week_improvements
sjanzou
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cpaulgilman
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Implementation looks good, I can see effect of January 1 day of week on outputs for load, energy charge, and demand charge for BTM configs, and in revenue TOD factors for FOM configs.
Pull Request Test Coverage Report for Build 18352938785Details
💛 - Coveralls |

Pull Request Template
Description
Add input start_day_of_year to relevant compute modules, and propagate effects to weekday/weekend schedules including:
Fixes #195
Corresponding branches and PRs:
Pairs with SAM PR TBD
Unit Test Impact:
Added tests to lib_util_test to verify new behavior
Other tests updates should just change function signature, not affect results.
Known compiler issue potentially affecting CMPvsamv1PowerIntegration_cmod_pvsamv1.NoFinancialModelSkyDiffuseAndIrradModels
Checklist
Reminders- this section can be deleted
[Checking for PySAM Incompatible API Changes]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files).
[When do the PySAM files need to be regenerated?]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files#when-do-the-pysam-files-need-to-be-regenerated-via-export_config)