Avoid computations with NaN in sssky_diffuse_table::compute #1355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
cf diagnostic at NREL/EnergyPlus#11245 I'm upstreaming my changes here
'recompact' failed with: ninja: error: tabs are not allowed, use spaces
Pull Request Test Coverage Report for Build 18205977035Details
💛 - Coveralls |
20 tasks
sjanzou
approved these changes
Oct 14, 2025
Collaborator
sjanzou
left a comment
sjanzou
left a comment
There was a problem hiding this comment.
Looks much better. Strange how 1 additional uncovered line was added... seemed like you shortened the logic branching.
| else | ||
| gamma[n] = (-M_PI / 2) + atan(arg[n]); | ||
| tan_tilt_gamma[n] = tan(surface_tilt * DTOR + gamma[n]); | ||
| Asky_shade[n] = M_PI + M_PI / pow((1 + tan_tilt_gamma[n] * tan_tilt_gamma[n]), 0.5); |
| else() | ||
| set(ADD_CFLAGS "${ADD_CFLAGS} -Wall -DWX_PRECOMP -DCHECK_SOLUTION -DYY_NEVER_INTERACTIVE -DPARSER_LP | ||
| -DINVERSE_ACTIVE=INVERSE_LUSOL -DRoleIsExternalInvEngine") | ||
| set(ADD_CFLAGS "${ADD_CFLAGS} -Wall -DWX_PRECOMP -DCHECK_SOLUTION -DYY_NEVER_INTERACTIVE -DPARSER_LP -DINVERSE_ACTIVE=INVERSE_LUSOL -DRoleIsExternalInvEngine") |
Collaborator
There was a problem hiding this comment.
This may cause a conflict with the ORTools branch but we will address when trying to merge that pull request
mjprilliman
approved these changes
Oct 31, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Template
Description
I'm upstreaming my changes here.
Fixes # (issue(s))
Corresponding branches and PRs:
Unit Test Impact:
[ new tests written? ]
[ expected changes in unit tests or speed of tests? ]
[ expected changes in test_results files? ]
Checklist
Reminders- this section can be deleted
[Checking for PySAM Incompatible API Changes]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files).
[When do the PySAM files need to be regenerated?]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files#when-do-the-pysam-files-need-to-be-regenerated-via-export_config)