Skip to content

Add support to run hybrids in SDKTool #1356

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
sjanzou wants to merge 2 commits into
base: develop
Choose a base branch
from
Open

Add support to run hybrids in SDKTool #1356

sjanzou wants to merge 2 commits into from

Conversation

@sjanzou
Copy link
Collaborator

@sjanzou sjanzou commented Oct 22, 2025 •
edited
Loading

Updates SDKTool var function to work with hybrids.

Specifically, add support to scripting.cpp for SSC_DATARR and SSC_DATMAT types.

To test use hybrids_sdktool branch o ssc and the develop branches of other repos and clean and build SAM and SDKTool

  1. In SAM, create and PVWatts Wind Battery Single Owner case
  2. Use the case menu and Code generation... and select "LK for SDKTool"
  3. Run the SDKTool from VS2022 or from explorer (on Windows)
  4. Select the recently build ssc.dll from SDKTool Module Browser
  5. Run the attached lk scripts (also has the generated json file if you want to skip steps 1 and 2)
    lk_SDKTool.zip

Expected results from the PVWatts_Wind_Battery_inputs_outputs.lk using the PVWatts_Wind_Battery.json generated file
image

Expected results from the test_datmat.lk SDKTool file
image

@sjanzou
Update scripting.cpp to handle var assignments for hybrids
a68216c 
sscvar_to_lkvar and lkvar_to_sscvar updated to handle SSC_DATARR type.
Still need to update to handle SSC_DATMAT type.
Ideally, would like to align with same functions in variables.cpp in SAM
@sjanzou
Add support for SSC_DATMAT in scripting.cpp for SDKTool
930639f
@sjanzou sjanzou self-assigned this Oct 22, 2025
@coveralls
Copy link

coveralls commented Oct 22, 2025

Pull Request Test Coverage Report for Build 18712078259

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 5 unchanged lines in 1 file lost coverage.
  • Overall coverage decreased (-0.004%) to 56.653%
Files with Coverage Reduction New Missed Lines %
ssc/shared/lib_geothermal.cpp 5 65.99%
Totals Coverage Status
Change from base Build 18355581094: -0.004%
Covered Lines: 66678
Relevant Lines: 117695
💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@mjprilliman mjprilliman Awaiting requested review from mjprilliman

@tyneises tyneises Awaiting requested review from tyneises

@janinefreeman janinefreeman Awaiting requested review from janinefreeman

@cpaulgilman cpaulgilman Awaiting requested review from cpaulgilman

Assignees

@sjanzou sjanzou

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sjanzou @coveralls