Skip to content

Conversation

@mjprilliman
Copy link
Collaborator

Pull Request Template

Description

-Update file readers to better handle missing or incomplete data
-Update mhk_costs to run calculations for different model selections, update capex-dependent capital costs accordingly

[ include directions for reviewers if necessary- what or how should they test or review ]
See email for review instructions

Corresponding branches and PRs:

SAM: NREL/SAM#2128
SAM-private: https://github.com/NREL/SAM-private/pull/138
[ which branches of wex, lk, and ssc should be built with this PR ]

[ link any corresponding PRs in other repos, i.e. NREL/ssc#x ]

Unit Test Impact:

[ new tests written? ]
New test written adding coverage to cmod_mhk_costs.cpp (previously none)
Rebuild CMake to add new test files

[ expected changes in unit tests or speed of tests? ]

[ expected changes in test_results files? ]

Checklist

  • requires help revision and I added that label
  • adds, removes, modifies, or deletes variables in existing compute modules
  • adds a new compute module
  • changes defaults
  • I've tagged this PR to a milestone

Reminders- this section can be deleted

[Checking for PySAM Incompatible API Changes]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files).

[When do the PySAM files need to be regenerated?]
(https://github.com/NREL/SAM/wiki/PySAM-Incompatible-API-Changes-&-Regenerating-PySAM-Files#when-do-the-pysam-files-need-to-be-regenerated-via-export_config)

@mjprilliman mjprilliman added this to the SAM Fall 2025 Release milestone Oct 24, 2025
@mjprilliman mjprilliman requested a review from sjanzou October 24, 2025 20:37
@mjprilliman mjprilliman self-assigned this Oct 24, 2025
@mjprilliman mjprilliman added the mhk marine hydrokinetic label Oct 24, 2025
@coveralls
Copy link

Pull Request Test Coverage Report for Build 18791542587

Details

  • 0 of 0 changed or added relevant lines in 0 files are covered.
  • 119 unchanged lines in 4 files lost coverage.
  • Overall coverage increased (+0.1%) to 57.733%

Files with Coverage Reduction New Missed Lines %
ssc/ssc/cmod_wavefile.cpp 11 73.4%
ssc/ssc/cmod_mhk_costs.cpp 18 85.77%
ssc/ssc/cmod_mhk_wave.cpp 34 83.0%
ssc/ssc/cmod_tidalfile.cpp 56 70.5%
Totals Coverage Status
Change from base Build 18721258026: 0.1%
Covered Lines: 69202
Relevant Lines: 119866

💛 - Coveralls

Copy link
Collaborator

@sjanzou sjanzou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test cases passing and equation updates match with pdf and GitHub Actions passing.

@sjanzou sjanzou merged commit efd6c0b into develop Oct 27, 2025
8 checks passed
@sjanzou sjanzou deleted the me-ui-updates-fy25 branch October 27, 2025 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

mhk marine hydrokinetic

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants