Skip to content

Batt Stateful array write controls and tests #584

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
brtietz merged 22 commits into from
Jun 23, 2021
Merged

Batt Stateful array write controls and tests #584

brtietz merged 22 commits into from
Jun 23, 2021

Conversation

@brtietz
Copy link
Collaborator

@brtietz brtietz commented Jun 18, 2021

Changed to battery stateful to prevent 100% values from persisting in the arrays for the NMC lifetime model:

  • Unassign the vartable value when the array is empty
    • Previous behavior left the old values in the vartable
  • Update unassign to work with uppercase variable names
  • Add tests to confirm behavior for batt stateful

dguittet and others added 22 commits April 23, 2021 13:19
@dguittet
add tests for all nmc cell data
00f2051
@dguittet
NREL NMC Lifetime Model Validation
adb543d
@dguittet
update results for other battery tests
009b97d
@dguittet
Merge branch 'develop' into nmc_life_tests
54c0952
@brtietz
changes to compile on Linux and Windows
b435c7e
@dguittet
fix broken tests, fix calculate_Uneg & calculate_Voc w/ tests added
3c7665f
@dguittet
Merge remote-tracking branch 'origin/nmc_life_tests' into nmc_life_tests
760e173
@dguittet
fix calculate_Uneg & calculate_Voc fxns
bf3be76
@brtietz
Merge branch 'develop' of https://github.com/NREL/ssc into nmc_life_t…
d027176 
…ests
@brtietz
Merge branch 'develop' of https://github.com/NREL/ssc into nmc_life_t…
42d3892 
…ests
@dguittet
add replacement test for lib_battery_lifetime_nmc_test
8ce020f
@brtietz
Merge branch 'nmc_life_tests' of https://github.com/NREL/ssc into nmc…
68dbf58 
…_life_tests
@dguittet
CMake options in all CMake files
1b8a0f0
@brtietz
Merge branch 'nmc_life_tests' of https://github.com/NREL/ssc into nmc…
3b084dc 
…_life_tests
@dguittet
Merge branch 'develop' into nmc_life_tests
95f0398
@dguittet
update replacement test results
a1b1f3c
@brtietz
Merge branch 'nmc_life_tests' of https://github.com/NREL/ssc into nmc…
b2ea3a1 
…_life_tests
@brtietz
Merge branch 'develop' of https://github.com/NREL/ssc into nmc_dod_ar…
a62d3fe 
…ray_tests
@brtietz
add some write controls to batt stateful for battery arrays. Addition…
7d611e0 
…al test for batt stateful that crosses a day for NMC lifetime
@dguittet
add case sensitivity to vartable::unassign
53c497f
@brtietz
Update test to confirm that unassign runs as expected
75e116c
@brtietz
update rainflow peaks test value in readjson
9961960
@brtietz brtietz added this to the SAM Fall 2021 Release milestone Jun 18, 2021
@brtietz brtietz requested a review from dguittet June 18, 2021 17:14
@brtietz brtietz merged commit 9961960 into develop Jun 23, 2021
@dguittet dguittet deleted the nmc_dod_array_tests branch June 29, 2021 13:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@dguittet dguittet dguittet approved these changes

Assignees

No one assigned

Labels

battery

Projects

None yet

Milestone

SAM Fall 2021 Release

Development

Successfully merging this pull request may close these issues.

3 participants

@brtietz @dguittet