Skip to content

Conversation

@dguittet
Copy link
Collaborator

@dguittet dguittet commented Jul 7, 2021

Function to check whether solar resource data is continuous was incorrectly stepping through minutes and leading to false negative for a valid 5 min file.

see NREL/pysam#88

@dguittet dguittet added the pv photovoltaic, pvsam, pvwatts label Jul 7, 2021
@dguittet dguittet added this to the SAM Fall 2021 Release milestone Jul 7, 2021
@dguittet dguittet requested a review from sjanzou July 9, 2021 09:29
Copy link
Collaborator

@sjanzou sjanzou left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@dguittet
Copy link
Collaborator Author

dguittet commented Jul 9, 2021

Thanks for the quick turnaround!

@dguittet dguittet merged commit f9e486e into develop Jul 9, 2021
@dguittet dguittet deleted the pv_5min branch July 9, 2021 10:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

pv photovoltaic, pvsam, pvwatts

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants