Weather and load forecasts for BTM #606
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ecast does nothing so far
dguittet
reviewed
Aug 20, 2021
ssc/cmod_battery.cpp
Outdated
| // day one is zeros | ||
| for (size_t idx = 0; idx != 24 * step_per_hour; idx++) | ||
| { | ||
| load_prediction.push_back(0); |
Collaborator
There was a problem hiding this comment.
why isn't this from the last 24 hours of the load forecast?
Collaborator
Author
There was a problem hiding this comment.
I was matching the convention from the weather file forecast:
Line 1328 in fcff96b
Collaborator
There was a problem hiding this comment.
I think so. I'd imagine if we're in year 2, and if we were doing lookahead, we'd use jan data for dec 31, and if doing lookbehind, we'd do the counterpart. This keeps continuity. What do you think?
…recast_for_btm
…look behind. this adds a cycle to the tests, which is expected
dguittet
approved these changes
Aug 24, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add options for load forecasts for behind the meter systems. Load forecast functions the same as actual load - can be either hourly for a single year (8760) or match the weather file timestep. Interpolation is handled by single_year_to_lifetime_interpolated.
Additionally, extend forecast options to generic system.
Pairs with SAM pull request: NREL/SAM#688