Battstor outputs for batt_life_model #608
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
brtietz
approved these changes
Aug 24, 2021
Collaborator
brtietz
left a comment
brtietz
left a comment
There was a problem hiding this comment.
Changes look good.
Is there a way to enforce the tabs/spaces convention more broadly? The pvsamv1 changes will cause conflicts with some of my branches, so it'd be good to make sure this only happens once. I remember something last year about .editorconfig - where were we on that process?
Collaborator
Author
|
Merged in latest from develop without merge conflict. Not sure how to automate the spacing in the vartables. For editorconfig, we're using the one that's included from wxWidgets but the settings are fairly short and don't account for specific use cases like this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some inputs to run battery lifetime models from the GUI