Connect outage vars to powerflow #618

brtietz · 2021-09-27T15:56:58Z

Adds crit_load_escalation to the relevant cmods. Brings the variables from the vartables into battery->advance such that the powerflow variables can use the outage code.

Needs to be paired with a SAM PR based on critical-load-ui branch, @cpaulgilman to create.

A future PR (ssc branch dispatch_for_grid_outage) will implement the outage behavior in dispatch, and clean up edge cases like the inverter night time loads.

Via email we had proposed making grid_outage and crit_load SSC outputs - should that happen on this PR or a different PR? If this one, which cmods are responsible for the output?

…a lifetime variable using that escalation factor. Allows for the lifetime critical load to be an array of zeros if crit load is not specified

…k for grid outage inputs.

…rflow code

…tage_vars_to_powerflow

…ed as [0] in the defaults. Lines that check for outage always check for size first

…tage_vars_to_powerflow

…e critical load met

…specifed for any step

sjanzou · 2021-09-28T05:48:40Z

Adds crit_load_escalation to the relevant cmods. Brings the variables from the vartables into battery->advance such that the powerflow variables can use the outage code.

Needs to be paired with a SAM PR based on critical-load-ui branch, @cpaulgilman to create.

A future PR (ssc branch dispatch_for_grid_outage) will implement the outage behavior in dispatch, and clean up edge cases like the inverter night time loads.

Via email we had proposed making grid_outage and crit_load SSC outputs - should that happen on this PR or a different PR? If this one, which cmods are responsible for the output?

I am branching off of your branch and Paul's SAM branch and including the monthly outputs for the Puerto Rico project

sjanzou

Looks good, I am running into a hanging case at 67.8% file attached to this pull request

SAM project file case "PV Com grid out hanging"
Test_Case.zip

sjanzou · 2021-09-28T05:40:00Z

ssc/cmod_battery.cpp

                        if (resilience) {
                            resilience->add_battery_at_outage_timestep(*batt->dispatch_model, lifetime_idx);
-                            resilience->run_surviving_batteries(p_crit_load[lifetime_idx % n_rec_single_year], power_input_lifetime[lifetime_idx]);
+                            resilience->run_surviving_batteries(p_crit_load_full[lifetime_idx], power_input_lifetime[lifetime_idx]);


Is p_crit_load_full the percentage (or timeseries) entered by the user?

p_crit_load_full is a timeseries extended to lifetime by the compute module. p_crit_load is the year 1 timeseries. The GUI converts percentages into a kW timeseries in the "$MIMO$ elecload" equations on the Electric Load Crit page.

sjanzou · 2021-09-28T05:40:29Z

ssc/cmod_battery.cpp

                    }
                }
+                if (!crit_load_specified && batt->analyze_outage) {
+                    throw exec_error("battery", "If grid_outage is specified in any time step, crit_load must have length > 0 and values > 0");


Thanks for adding this!

sjanzou · 2021-09-28T05:41:53Z

ssc/cmod_pvsamv1.cpp

                if (resilience) {
                    resilience->add_battery_at_outage_timestep(*batt->dispatch_model, idx);
-                    resilience->run_surviving_batteries(p_crit_load_in[idx % nrec], sharedInverter->powerAC_kW, dcPower_kW,
+                    resilience->run_surviving_batteries(p_crit_load_full[idx], sharedInverter->powerAC_kW, dcPower_kW,


All are full lifetime now, yeah!

sjanzou · 2021-09-28T08:37:51Z

Looks good, I am running into a hanging case at 67.8% file attached to this pull request

SAM project file case "PV Com grid out hanging"
Test_Case.zip

The issue is with peak shaving dispatch and not the grid outage. With either case in the above SAM file, the peak dispatch option will hang in SAM at 67/8% and debugging in the SDKTool, after the fixes in the Fix_issues branches of ssc and SAM to generate the lk script and match the grid targets dispatch option results, the issue is a stack overflow in the BatteryPowerFlow::calculateACConnected:

Failing for peak shaving dispatch per comment above

sjanzou · 2021-09-28T10:07:50Z

Next issue is hanging for grid power targets and timestep resilency

Same issue as above with Test_Case.sam second case with time step resilency

Trace issue to possible incorrect sign - above cases run fine when sign is changed per pull request 619

add tolerance to grid charging check to allow for floating point issues

sjanzou · 2021-09-28T21:25:13Z

#620 merge still fails for case 3 of attached file per comment
Test_Case.zip

sjanzou · 2021-09-29T09:24:53Z

Can we drop #618 and just use 620 and the fix you do in dispatch_for_grid_outage?

sjanzou

Can we drop #618 and just use 620 and the fix you do in dispatch_for_grid_outage? Or, merge both in and then start a new branch to fix the resilency runner issue?

sjanzou · 2021-09-29T09:25:38Z

shared/lib_battery_powerflow.cpp

    // Error checking trying to charge from grid when not allowed
    if (!m_BatteryPower->canGridCharge && P_battery_ac < -tolerance) {
-        if ((fabs(P_grid_ac - P_grid_to_load_ac) > tolerance) && (-P_grid_ac > P_grid_to_load_ac)) {
+        if ((fabs(P_grid_ac - P_grid_to_load_ac) > tolerance) && (-P_grid_ac > P_grid_to_load_ac + tolerance)) {


Is this in 620, too?

I merged 620 into this branch, so yes.

cpaulgilman · 2021-09-29T21:11:06Z

This SAM pull request should be ready to merge with this when ready: NREL/SAM#707

…tage_vars_to_powerflow

…/NREL/ssc into connect_outage_vars_to_powerflow

…verflow problems

brtietz · 2021-09-29T21:47:16Z

@sjanzou In the interest of getting this merged sooner, I brought over a few key lines from dispatch_for_grid_outages that I think solve the stack overflow problems on this branch. The third test case works for me, let me know if anything else breaks.

dispatch_for_grid_outage is still broken as of this writing, since that code introduced some new problems. I'll try to get those problems fixed this week.

sjanzou

All Test_case.sam cases running now with this branch (dispatch_for_grid_outages still broken as noted), this looks good to merge along with corresponding SAM pull request from Paul. Thanks!

brtietz added 9 commits August 27, 2021 10:26

add escalation factor for critical load and convert critical load to …

728ff01

…a lifetime variable using that escalation factor. Allows for the lifetime critical load to be an array of zeros if crit load is not specified

Connect grid outage ssc inputs to the powerflow code. Add length chec…

9b4087f

…k for grid outage inputs.

pass critical load into battery advance so it can be send to the powe…

43b0f7b

…rflow code

Merge branch 'develop' into connect_outage_vars_to_powerflow

22b301d

Merge branch 'develop' of https://github.com/NREL/ssc into connect_ou…

3608788

…tage_vars_to_powerflow

remove exception to outage step length such that outage can be assign…

b0a6f33

…ed as [0] in the defaults. Lines that check for outage always check for size first

Merge branch 'develop' of https://github.com/NREL/ssc into connect_ou…

332cd85

…tage_vars_to_powerflow

fix code that determines whether or not to display outage outputs lik…

eb48aba

…e critical load met

add ssc exception if crit load is 0 for all steps but grid outage is …

1c362bb

…specifed for any step

brtietz added enhancement battery labels Sep 27, 2021

brtietz added this to the SAM Fall 2021 Release milestone Sep 27, 2021

brtietz requested review from cpaulgilman and sjanzou September 27, 2021 15:56

cpaulgilman mentioned this pull request Sep 27, 2021

UI for Critical Loads and Grid Outage for all BTM Storage Configs NREL/SAM#707

Merged

sjanzou previously approved these changes Sep 28, 2021

View reviewed changes

sjanzou self-requested a review September 28, 2021 08:38

brtietz added 2 commits September 28, 2021 11:53

add tolerance to grid charging check to allow for floating point issues

bb063be

Merge pull request #620 from NREL/add_tolerance_to_powerflow_error_check

9a9fa13

add tolerance to grid charging check to allow for floating point issues

brtietz mentioned this pull request Sep 28, 2021

add tolerance to grid charging check to allow for floating point issues #620

Merged

sjanzou requested changes Sep 29, 2021

View reviewed changes

brtietz added 2 commits September 29, 2021 15:41

Merge branch 'develop' of https://github.com/NREL/ssc into connect_ou…

08aaf37

…tage_vars_to_powerflow

Merge branch 'connect_outage_vars_to_powerflow' of https://github.com…

0212d6b

…/NREL/ssc into connect_outage_vars_to_powerflow

bring over a few fixes from dispatch_for_grid_outage to solve stack o…

d07368a

…verflow problems

sjanzou approved these changes Sep 30, 2021

View reviewed changes

brtietz merged commit d07368a into develop Sep 30, 2021

brtietz deleted the connect_outage_vars_to_powerflow branch December 7, 2021 16:50

Connect outage vars to powerflow #618

Connect outage vars to powerflow #618

Uh oh!

Conversation

brtietz commented Sep 27, 2021

Uh oh!

sjanzou commented Sep 28, 2021

Uh oh!

sjanzou left a comment

Choose a reason for hiding this comment

Uh oh!

sjanzou Sep 28, 2021

Choose a reason for hiding this comment

Uh oh!

brtietz Sep 28, 2021

Choose a reason for hiding this comment

Uh oh!

sjanzou Sep 28, 2021

Choose a reason for hiding this comment

Uh oh!

sjanzou Sep 28, 2021

Choose a reason for hiding this comment

Uh oh!

sjanzou commented Sep 28, 2021

Uh oh!

sjanzou commented Sep 28, 2021

Uh oh!

sjanzou commented Sep 28, 2021

Uh oh!

sjanzou commented Sep 29, 2021

Uh oh!

sjanzou left a comment

Choose a reason for hiding this comment

Uh oh!

sjanzou Sep 29, 2021

Choose a reason for hiding this comment

Uh oh!

brtietz Sep 29, 2021

Choose a reason for hiding this comment

Uh oh!

cpaulgilman commented Sep 29, 2021

Uh oh!

brtietz commented Sep 29, 2021

Uh oh!

sjanzou left a comment • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

sjanzou left a comment •

edited

Loading