Add missing vtab_lcos_input so that cash_loan will run from lk script #619
Conversation
| P_battery_ac = P_battery_ac > 0 ? P_battery_ac : 0; // Don't swap from charging to discharging | ||
| m_BatteryPower->powerBatteryDC = -P_battery_ac * m_BatteryPower->singlePointEfficiencyACToDC; | ||
| // m_BatteryPower->powerBatteryDC = -P_battery_ac * m_BatteryPower->singlePointEfficiencyACToDC; | ||
| m_BatteryPower->powerBatteryDC = P_battery_ac * m_BatteryPower->singlePointEfficiencyACToDC; |
There was a problem hiding this comment.
This code will only run when the battery is charging (see line 489), therefore the sign on line 493 is correct. We don't want this code swapping from charging to discharging, which is what line 494 now does.
If there's a less confusing way to do the sign swap between 491 and 493, I'm open to that, but at the end of this section powerBatteryDC needs to be a negative number. The StackOverflow issue needs to be solved between lines 304 and 385. (I'll try to narrow that down today)
There was a problem hiding this comment.
My hunch on the lines was incorrect - proposed fix here: https://github.com/NREL/ssc/pull/620/files
Happy to accept a PR with just the "batt_annual_charge_energy" change.
sjanzou
changed the title
|
I cherry-picked 23e4bac over to develop so we get that change included while I debug the powerflow stack overflow. |
|
Great!
I will delete pull request 619 if you have not already.
Thanks,
steve
…On Wed, 29 Sept 2021 at 14:13, Brian Mirletz ***@***.***> wrote:
I cherry-picked 23e4bac
<23e4bac>
over to develop so we get that change included while I debug the powerflow
stack overflow.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#619 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/ABRSQB2U4HNFQ32GBC4OIDDUENXOXANCNFSM5E43HYAQ>
.
|
No description provided.