Fix SSC 621 - cycle degradation penalty is nan or zero #627
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… cycle degradation. prevent divide by zero errors for new degradation algorithms
mjprilliman
reviewed
Oct 28, 2021
Collaborator
mjprilliman
left a comment
mjprilliman
left a comment
There was a problem hiding this comment.
Code looks good to me. Will check degradation penalty results once my SAM tests are finished running.
Comment on lines
+194
to
+196
| { SSC_INPUT, SSC_ARRAY, "om_batt_replacement_cost" , "Replacement cost 1" , "$/kWh" , "" , "System Costs" , "?=0.0" , "" , "" }, | ||
| { SSC_INPUT, SSC_NUMBER, "om_replacement_cost_escal" , "Replacement cost escalation" , "%/year" , "" , "System Costs" , "?=0.0" , "" , "" }, | ||
|
|
Collaborator
There was a problem hiding this comment.
Why do these need to be in the cmod_battery vartable rather than in vtab_oandm in common.cpp?
Collaborator
Author
There was a problem hiding this comment.
The battery compute modules don't include that vartable definition (see line 2014 of cmod_battery, or line 928 if cmod_pvsamv1). I thought it was better to duplicate the lines than include unnecessary variables, but I'm open to other options.
Collaborator
There was a problem hiding this comment.
No I like your solution. I was mostly asking for my own understanding
mjprilliman
approved these changes
Oct 28, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#621