Skip to content

Improve two-button-shutter stop semantics #164

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Draft
wants to merge 2 commits into
base: master
Choose a base branch
from
Draft

Improve two-button-shutter stop semantics #164

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
6757ff8
MNT: change pause -> stop
tacaswell Aug 11, 2022
9f5ab1b
WIP: make stop/pause closing behavior configurable
tacaswell Nov 1, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions nslsii/devices.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -97,7 +97,7 @@ def cmd_retry_cb(value, timestamp, **kwargs):

return st

def stop(self, *, success=False):
def pause(self):
import time
prev_st = self._set_st
if prev_st is not None:
Expand All @@ -123,7 +123,7 @@ def unstage(self):
self._was_open = False
return super().unstage()

def __init__(self, *args, **kwargs):
def __init__(self, *args, close_on_pause=True, close_on_stop=True, **kwargs):
self._was_open = False
super().__init__(*args, **kwargs)
self._set_st = None
Expand Down