FIX: Two critical fixes to Eurotherm #58
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Instead of checking `is_alive()` on each call of the callback, start the timer outside the callback so it happens exactly once. Using `is_alive()` raised errors once the timer stopped because it returns `False` when the thread *is started* but is also dead.
Codecov Report
@@ Coverage Diff @@
## master #58 +/- ##
==========================================
+ Coverage 42.46% 52.24% +9.77%
==========================================
Files 10 11 +1
Lines 584 691 +107
==========================================
+ Hits 248 361 +113
+ Misses 336 330 -6
Continue to review full report at Codecov.
|
awalter-bnl
approved these changes
Apr 15, 2019
Contributor
awalter-bnl
left a comment
awalter-bnl
left a comment
There was a problem hiding this comment.
These changes look good to me
Contributor
|
we should solve the Travis error first |
Member
|
The failure looked like it was due to flake8 issues in code not touched by this PR, power-cycled to re-run against current master to see if that just fixes it. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I used this against the
caproto.ioc_examples.thermo_simIOC for the tutorialand found a couple bugs.