Pre-bundle qrcode dep for kiosk enrollment QR code#37
Open
OSPFNeighbour wants to merge 1 commit into
Open
Conversation
KioskEnrollment.tsx imports qrcode but it wasn't in optimizeDeps.include, so Vite discovered it mid-request on first load of the enrollment screen and force-reloaded, aborting the import with "Importing a module script failed." Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Member
|
I can't reproduce this issue. Not saying this code change isn't good for other reasons. |
Member
|
Sorry to be pedantic but I want to make sure we understand what this does. I believe exceljs was added to this list because it forces vite to bundle it separately from everything else so it can be neatly asynchronously imported on demand and it's ~1MB compiled doesn't slow down every page load - hence the use of the functional import. We could do the same for qrcode (ie load on demand) but it's pretty tiny (71kB). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
KioskEnrollment.tsx imports qrcode but it wasn't in optimizeDeps.include, so Vite discovered it mid-request on first load of the enrollment screen and force-reloaded, aborting the import with "Importing a module script failed."