feat: add configurable PR status animation sound#60
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Motivation
Description
src/views/DashboardView.vuefor "動畫音效" with a toggle, file upload (audio/*), a "恢復預設音效" button and a preview button, and a label that shows the current sound name.tattoo-dashboard-status-animation-sound-enabled,tattoo-dashboard-status-animation-sound-data-url, andtattoo-dashboard-status-animation-sound-nameand a default sound path/cash.mp3(file placed underpublic/cash.mp3).HTMLAudioElementto preload/play the selected sound.playStatusAnimationSound()is invoked whentriggerPrStatusAnimation()runs, and added preview/play utilities (previewStatusAnimationSound,uploadStatusAnimationSound,clearCustomStatusAnimationSound,applyStatusAnimationSoundEnabled).Testing
npm run buildwhich completed successfully and produced thedistartifacts..github/workflows/deploy-pages.ymlstill runsnpm run buildand uploadsdist, preserving Pages workflow compatibility.Codex Task