Skip to content

Conversation

@ntietje1
Copy link
Collaborator

@ntietje1 ntietje1 commented Apr 10, 2025

Summary

  • Adds a backend endpoint for getting a base repo
  • Changes assignment page's link from linking to the template repository to the base repository (you can still get to the template FROM the base repo)
  • Adds reuse of the react query cache for assignments (blazingly fast speeds)
  • Note: I accidentally branched off of workflow-rework
  • Made a ticket for a UI minor bug KHO-337 (button styling issue)

Checklist

  • I have performed a self-review of my code
  • I have reached out to another developer to review my code
  • New and existing unit tests pass locally with my changes
  • All Lint and CI checks are passing

@ntietje1 ntietje1 changed the base branch from main to feature/workflow-rework April 10, 2025 17:54
@ntietje1 ntietje1 requested a review from Copilot April 11, 2025 00:24
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.

Comments suppressed due to low confidence (2)

frontend/src/pages/Assignments/Assignment/index.tsx:32

  • [nitpick] Consider renaming 'base_url' to 'baseUrl' for consistency with common JavaScript/TypeScript naming conventions.
const base_url: string = import.meta.env.VITE_PUBLIC_FRONTEND_DOMAIN as string;

frontend/src/pages/Assignments/Assignment/index.tsx:66

  • The new loading state variables (assignmentIsLoading and assignmentBaseRepoIsLoading) are declared but not used. It might be beneficial to render a loading spinner when these values are true to improve user experience.
return ( assignment && (

@ntietje1 ntietje1 changed the title Feature/assignment base repo link Feature/assignment base repo link (KHO-338) Apr 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants