-
Notifications
You must be signed in to change notification settings - Fork 2
Feature/student work page upgrade (KHO-339) #228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
ntietje1
wants to merge
11
commits into
feature/assignment-base-repo-link
Choose a base branch
from
feature/student-work-page-upgrade
base: feature/assignment-base-repo-link
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Feature/student work page upgrade (KHO-339) #228
ntietje1
wants to merge
11
commits into
feature/assignment-base-repo-link
from
feature/student-work-page-upgrade
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…-work-page-upgrade
…-work-page-upgrade
…-work-page-upgrade
Contributor
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Copilot reviewed 7 out of 7 changed files in this pull request and generated no comments.
Comments suppressed due to low confidence (3)
frontend/src/pages/Assignments/StudentSubmission/index.tsx:42
- Calling ErrorToast directly during render may trigger duplicate alerts on re-renders. Consider wrapping this call in a useEffect hook that watches submissionError to trigger the toast only once per error occurrence.
if (submissionError) { ErrorToast("Error loading submission data", "submissionError"); }
frontend/src/pages/Assignments/StudentSubmission/index.tsx:46
- Directly calling ErrorToast in the render path may result in repeated notifications. Moving this logic into a useEffect hook triggered by analyticsError will help control side effects more reliably.
if (analyticsError) { ErrorToast("Error loading analytics data", "analyticsError"); }
frontend/src/hooks/useStudentWorks.ts:127
- Using Date objects as keys in a Map can lead to issues because different Date instances with the same time are not considered equal. Consider using a consistent key format (e.g., an ISO string) for reliable date comparisons.
if (!commitsPerDay.has(currentDate)) { commitsPerDay.set(new Date(currentDate), 0); }
…-work-page-upgrade
…-work-page-upgrade
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Checklist