[chore]春のlint修正祭り〜API編〜 #1794
Draft
[chore]春のlint修正祭り〜API編〜 #1794
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| if group.nil? | ||
| next | ||
| def output_sub_reps_csv | ||
| if params[:fes_year_id].to_id.zero? |
There was a problem hiding this comment.
Using 'to_id' for converting params to integer is likely a mistake if no such method exists. Consider replacing 'to_id' with 'to_i' to ensure proper integer conversion.
Suggested change
| if params[:fes_year_id].to_id.zero? | |
| if params[:fes_year_id].to_i.zero? |
Copilot uses AI. Check for mistakes.
| end | ||
| end | ||
| if @employees.count.zero? | ||
| render json: fmt(not_found, [], 'Not found empolees') |
There was a problem hiding this comment.
The error message contains a typo ('empolees' should be 'employees').
Suggested change
| render json: fmt(not_found, [], 'Not found empolees') | |
| render json: fmt(not_found, [], 'Not found employees') |
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
対応Issue
resolve #0
概要
実装詳細
画面スクリーンショット等
テスト項目
備考
コードを眺めた感じ、ぱっと見破壊的変更はなさそうだった
動かして確認してないから、大丈夫か確認して欲しい