Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adds compatibility with NVIDIA AI Workbench #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Adds compatibility with NVIDIA AI Workbench #18
Changes from 23 commits
b3595de
5f331ac
e19e6fb
6a9830d
95791b4
611b656
d10178d
9c212ac
c0e3131
087801d
c05d4c0
9ac5cfb
a144013
5651e49
1f30fe7
fe9516d
8f02768
eaa08d3
1292b65
ee14f65
f1729f9
ac11eca
508bc4c
82da3ec
6a7cc43
6146cec
7a2e66c
af6a4d1
637d962
30a2557
7205837
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
why was this needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Every project in AI Workbench is src code that is containerized automatically using a base container with added project-level customizations on top of it, like packages, variables, etc. The main project container environment for this BP project provides a Jupyterlab IDE by default so users can develop, write code, and customize the BP in the project environment.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we keep this file inside
workbench
directory?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AI Workbench expects environment setup files at the top level of the repo and metadata files under the top level
.project
hidden folder.Env setup files include
requirements.txt
,variables.env
,apt.txt
,preBuild.bash
,postBuild.bash
, etc. More details here.In this case, we only have a need for the former two files, the others are not needed and therefore not included in the repo.
This file does not affect the flow for users running the BP outside of AIWB as they would still run the flow via the main README instructions.