update sdrc tag with gRPC ADS envoy support#1107
Conversation
Greptile SummaryThis PR updates the
Confidence Score: 4/5Safe to merge if the dev-registry image is intentionally temporary and access has been confirmed for all expected deployers; otherwise the image pull will fail for anyone using standard NGC credentials scoped to the old org. The core logic change — wiring up WDM_XDS_GRPC_ADS_ENABLED — is correct and well-structured across both deployment paths. The concern is the image itself: it moved from the public nvidia/vss-core NGC namespace to nv-metropolis-dev/metropolis-analytic, a dev-scoped registry, at a version that regresses from 3.2.0 to 3.0.0-prd.9 with a pre-release suffix. Users who provision NGC credentials following the existing documentation will be unable to pull the new image, and the reference docs were not updated to reflect the changed org. deploy/docker/services/infra/sdrc/docker-compose.yaml and deploy/helm/services/infra/charts/sdrc/values.yaml — both now reference the dev-registry image. Also skills/vss-manage-video-io-storage/references/ docs still point to the old org and tag. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Deploy sdr-controller] --> B{Deployment path}
B -->|Docker Compose| C["Image: nv-metropolis-dev/.../sdr-mw-l:3.0.0-prd.9\nWDM_XDS_GRPC_ADS_ENABLED=${WDM_XDS_GRPC_ADS_ENABLED:-true}"]
B -->|Helm| D["values.yaml: repository=nv-metropolis-dev/.../sdr-mw-l\ntag=3.0.0-prd.9\nruntimeEnv.WDM_XDS_GRPC_ADS_ENABLED=true"]
D --> E["_helpers.tpl renders env\ndefault 'false' if key absent\nvalues.yaml supplies 'true'"]
C --> F{ADS enabled?}
E --> F
F -->|true| G[Envoy uses gRPC ADS-backed xDS]
F -->|false| H[Envoy uses static/file xDS]
G --> I[sdr-controller runtime]
H --> I
%%{init: {'theme': 'base', 'themeVariables': {"darkMode": true, "background": "#0d1117", "primaryColor": "#21262d", "primaryTextColor": "#e6edf3", "primaryBorderColor": "#8b949e", "lineColor": "#8b949e", "textColor": "#e6edf3", "edgeLabelBackground": "#161b22", "actorBkg": "#21262d", "actorBorder": "#8b949e", "actorTextColor": "#e6edf3", "actorLineColor": "#8b949e", "signalColor": "#8b949e", "signalTextColor": "#e6edf3", "noteBkgColor": "#373320", "noteBorderColor": "#d4a72c", "noteTextColor": "#f0e6c0", "labelBoxBkgColor": "#21262d", "labelBoxBorderColor": "#8b949e", "labelTextColor": "#e6edf3", "loopTextColor": "#e6edf3", "activationBkgColor": "#30363d", "activationBorderColor": "#8b949e"}}}%%
flowchart TD
A[Deploy sdr-controller] --> B{Deployment path}
B -->|Docker Compose| C["Image: nv-metropolis-dev/.../sdr-mw-l:3.0.0-prd.9\nWDM_XDS_GRPC_ADS_ENABLED=${WDM_XDS_GRPC_ADS_ENABLED:-true}"]
B -->|Helm| D["values.yaml: repository=nv-metropolis-dev/.../sdr-mw-l\ntag=3.0.0-prd.9\nruntimeEnv.WDM_XDS_GRPC_ADS_ENABLED=true"]
D --> E["_helpers.tpl renders env\ndefault 'false' if key absent\nvalues.yaml supplies 'true'"]
C --> F{ADS enabled?}
E --> F
F -->|true| G[Envoy uses gRPC ADS-backed xDS]
F -->|false| H[Envoy uses static/file xDS]
G --> I[sdr-controller runtime]
H --> I
Reviews (3): Last reviewed commit: "Merge branch 'develop' into cailani/sdrc..." | Re-trigger Greptile |
![greptile-apps[bot]](https://avatars.githubusercontent.com/in/867647?s=60&v=4){kind=small}
Co-authored-by: greptile-apps[bot] <165735046+greptile-apps[bot]@users.noreply.github.com>
|
|
|
1 participant
Description
Checklist
uv run pre-commit installonce, then hooks run on everygit commit).git commit -sadds aSigned-off-bytrailer that certifies you have the right to submit the change under Apache-2.0).