added fitted attr to stat op and checks in executor #333
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
karlhigley
reviewed
May 23, 2023
| @@ -27,6 +27,8 @@ class StatOperator(BaseOperator): | |||
| on top of the Operator class. | |||
| """ | |||
|
|
|||
| fitted = False | |||
There was a problem hiding this comment.
I'm still somewhat concerned that this variable needs to be on the instance level instead of the class level. It works in our test case because we only have one op that needs fitting, but I have a hunch this is going to cause weird errors that are difficult to troubleshoot when we have more than one.
There was a problem hiding this comment.
Unless we have some code that runs StatOperator.fitted = True, changing the class-level attribute we should be ok? If we're concerned about that, maybe can implement an __init__ method that sets the fitted attribute?
Documentation preview |
oliverholworthy
approved these changes
May 23, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the fitted (bool) attribute to all Stat Operators. This boolean is set to true after an operator has been fit. You can now manually specify to "refit" a fitted StatOperator in the fit method call. And transform checks to ensure all Stat Operators have been fitted before running transform on a graph.