Fix an issue with data format detection in executors #335
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a stray line of code in the data format detection that converted to `TensorTable` before detecting the format, which was probably a leftover from the development process. It didn't affect anything yet, since Systems wasn't using these executors and the affected case is only relevant in Systems. Migrating Systems to use these executors instead of custom Workflow running code surfaced the issue.
Documentation preview |
jperez999
approved these changes
May 25, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a stray line of code in the data format detection that converted to
TensorTablebefore detecting the format, which was probably a leftover from the development process. It didn't affect anything yet, since Systems wasn't using these executors and the affected case is only relevant in Systems. Migrating Systems to use these executors instead of custom Workflow running code surfaced the issue.(NVIDIA-Merlin/systems#354 depends on this)