Skip to content

adding rapids runner #338

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 13 commits into
base: main
Choose a base branch
from
Open

adding rapids runner #338

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
13 commits
Select commit Hold shift + click to select a range
5dc0e6a
adding rapids runner
jperez999 May 30, 2023
f52a16d
revert changes
jperez999 May 30, 2023
5846e79
added new ci workflow for runner test
jperez999 May 30, 2023
323ae0f
commit bump
jperez999 May 30, 2023
54cbc31
Merge branch 'main' into rapids-run
jperez999 May 30, 2023
ec7f6cd
testing credentials and added label to actionlint
jperez999 Jul 3, 2023
42ef4df
add gpus flag to docker run commnad
jperez999 Jul 3, 2023
1cd3c5c
add corrected env flag
jperez999 Jul 3, 2023
88d7804
add in branch name and change directory target
jperez999 Jul 3, 2023
419d809
remove unnecessary steps
jperez999 Jul 3, 2023
07f03b8
run correct test command
jperez999 Jul 4, 2023
e1b74cc
remove test ci yaml file
jperez999 Jul 5, 2023
40ea160
Merge branch 'main' into rapids-run
karlhigley Jul 6, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions .github/actionlint.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,3 +3,4 @@ self-hosted-runner:
labels:
- 1GPU
- 2GPU
- linux-amd64-gpu-p100-latest-1
30 changes: 30 additions & 0 deletions .github/workflows/gpu-ci-docker.yaml
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
name: GPU CI

on:
push:
branches:
- "pull-request/[0-9]+"

jobs:
gpu-ci-docker:
runs-on: linux-amd64-gpu-p100-latest-1

container:
image: nvcr.io/nvstaging/merlin/merlin-ci-runner:latest
credentials:
username: ${{ secrets.SVC_DOCKER_USER }}
password: ${{ secrets.SVC_DOCKER_TOKEN }}
env:
NVIDIA_VISIBLE_DEVICES: ${{ env.NVIDIA_VISIBLE_DEVICES }}
steps:
- uses: actions/checkout@v3
with:
fetch-depth: 0
- name: Get Branch name
id: get-branch-name
uses: NVIDIA-Merlin/.github/actions/branch-name@6f0539fba24f60da2aee63c5925bee7cee3206e3
- name: Run tests
run: |
merlin_branch="${{ steps.get-branch-name.outputs.branch }}"
MERLIN_BRANCH=$merlin_branch COMPARE_BRANCH=$merlin_branch \
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These env vars are not required here.

  • MERLIN_BRANCH is used in other places where we need to install other merlin packages from the equivalent branch ( release branch or development branch). In this test-gpu tox environment we only install the core package.
    • the get-branch-name step can also be removed here too since we won't use it if MERLIN_BRANCH is removed
  • COMPARE_BRANCH is something currently only used in Merlin Models to inspect the diff and label parts as changed or unchanged (so that tests using TensorFlow only run if the tensorflow code has changed).

tox -e test-gpu