Skip to content

Correct dask cluster type check #341

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Conversation

oliverholworthy
Copy link
Member

Follow-up to #339

Corrects check of dask cluster type. LocalCUDACluster is a subclass of LocalCluster and the isinstance check was intended to check the type explictly.

@oliverholworthy oliverholworthy added bug Something isn't working skip-changelog Exclude from change log labels Jun 1, 2023
@oliverholworthy oliverholworthy added this to the Merlin 23.06 milestone Jun 1, 2023
@oliverholworthy oliverholworthy self-assigned this Jun 1, 2023
@github-actions
Copy link

github-actions bot commented Jun 1, 2023

Documentation preview

https://nvidia-merlin.github.io/core/review/pr-341

@oliverholworthy oliverholworthy merged commit 56579d4 into NVIDIA-Merlin:main Jun 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working skip-changelog Exclude from change log
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants