migrate metadata operators to core #344
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Documentation preview |
merlin/dag/ops/add_metadata.py
Outdated
| self.tags = tags or [] | ||
| self.properties = properties or {} | ||
|
|
||
| def transform( |
There was a problem hiding this comment.
This appears to be the default implementation of transform in the BaseOperator. Could this be omitted or, are we adding this here as part of a convention of adding a transform for every operator?
|
Should we add these to |
oliverholworthy
approved these changes
Jun 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR migrates all the add metadata operators to core. This will allow them to be used in other parts of merlin, like systems. These are general operators that manipulate schemas. They are not required to be located in the nvtabular repo. By moving these operators to core, we remove the nvtabular import requirement for these ops.