Skip to content

Increase tolerance in transformer tests #1111

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
nv-alaiacano merged 2 commits into from
May 25, 2023
Merged

Increase tolerance in transformer tests #1111

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
55068f0
Increase tolerance in transformer tests
sararb May 24, 2023
44308db
Merge branch 'main' into transformer-unit-test
sararb May 24, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions merlin/models/tf/utils/testing_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -113,10 +113,10 @@ def model_test(
if isinstance(model_preds, dict):
for task_name in model_preds:
tf.debugging.assert_near(
model_preds[task_name], loaded_model_preds[task_name], atol=1e-5
model_preds[task_name], loaded_model_preds[task_name], atol=1e-4
)
else:
tf.debugging.assert_near(model_preds, loaded_model_preds, atol=1e-5)
tf.debugging.assert_near(model_preds, loaded_model_preds, atol=1e-4)

loaded_model.compile(run_eagerly=run_eagerly, optimizer=optimizer, **kwargs)
loaded_model.fit(iter(batch))
Expand Down
2 changes: 1 addition & 1 deletion tests/unit/tf/transformers/test_block.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ def test_retrieval_transformer(sequence_testing_data: Dataset, run_eagerly):
assert list(item_embeddings.shape) == [101, d_model]
predicitons_2 = np.dot(query_embeddings, item_embeddings.T)

np.testing.assert_allclose(predictions, predicitons_2, atol=1e-6)
np.testing.assert_allclose(predictions, predicitons_2, atol=1e-4)


def test_transformer_encoder():
Expand Down