fix(ci_tests): use safe_load in generate ci tests#1763
Open
basheer-cloud wants to merge 3 commits intoNVIDIA-NeMo:mainfrom
Open
fix(ci_tests): use safe_load in generate ci tests#1763basheer-cloud wants to merge 3 commits intoNVIDIA-NeMo:mainfrom
basheer-cloud wants to merge 3 commits intoNVIDIA-NeMo:mainfrom
Conversation
basheer-cloud
requested review from
HuiyingLi,
ZhiyuLi-Nvidia,
adil-a,
akoumpa,
hemildesai and
pthombre
as code owners
akoumpa
reviewed
Apr 10, 2026
akoumpa
reviewed
Apr 10, 2026
akoumpa
reviewed
Apr 10, 2026
|
|
||
| def tpool_patch_merger( | ||
| x: torch.Tensor, grid_thws: torch.Tensor, merge_kernel_size: List[int] = [2, 2] | ||
| x: torch.Tensor, grid_thws: torch.Tensor, merge_kernel_size: List[int] = None |
Contributor
There was a problem hiding this comment.
I would keep this as [2, 2]
akoumpa
reviewed
Apr 10, 2026
|
|
||
|
|
||
| def patch_merger(x: torch.Tensor, grid_hws: torch.Tensor, merge_kernel_size: List[int] = [2, 2]) -> List[torch.Tensor]: | ||
| def patch_merger(x: torch.Tensor, grid_hws: torch.Tensor, merge_kernel_size: List[int] = None) -> List[torch.Tensor]: |
thomasdhc
reviewed
Apr 10, 2026
chtruong814
added
waiting-for-customer
Contributor
|
/ok to test d789859 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
I ran into this while reading through the code path around tests/ci_tests/utils/generate_ci_tests.py. Use safe_load in generate ci tests. yaml.load on untrusted input can construct arbitrary Python objects. I kept the patch small and re-ran syntax checks after applying it.
Backward-compat note: This changes a public function signature by replacing mutable defaults with None guards. Call sites stay source-compatible, but callers introspecting defaults will see None now.