Draft
Conversation
Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Contributor
Author
|
/ok to test 66a2804 |
The megatron_fsdp_strategy_parallelize function was missing the call to _update_attention_head_counts_for_tp after applying tensor parallelism via parallelize_module. The FSDP2 path (DefaultParallelizationStrategy.parallelize) already performs this update, but the MegatronFSDP path did not. Without this update, attention modules retain global head counts after TP sharding, which can cause incorrect GQA behavior and DTensor shape mismatches that manifest as NCCL collective hangs. Signed-off-by: Alexandros Koumparoulis <akoumparouli@nvidia.com>
Contributor
Author
|
/ok to test db1f660 |
Contributor
Author
|
/ok to test ce0d6ab |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do ?
What it does: Benchmarks Qwen3-Next-80B-A3B-Instruct with TE + DeepEP, 8 GPUs. Crashes on the very first forward pass.
Traceback:
TypeError: Qwen3NextGatedDeltaNet.forward() got an unexpected keyword argument 'position_ids'
Root cause: In nemo_automodel/components/models/qwen3_next/model.py:77, the decoder layer passes position_ids to self.linear_attn(). But Qwen3NextGatedDeltaNet.forward() doesn't accept that parameter — gated delta-nets encode position implicitly and have a different signature than standard attention.
So Qwen3NextGatedDeltaNet.forward() accepts:
Changelog
Before your PR is "Ready for review"
Pre checks:
If you haven't finished some of the above items you can still open "Draft" PR.
Additional Information