Skip to content

refactor: Remove separate moe_mesh references#1824

Open
edjson wants to merge 2 commits intoNVIDIA-NeMo:mainfrom
edjson:feat/device-mesh-consolidation
Open

refactor: Remove separate moe_mesh references#1824
edjson wants to merge 2 commits intoNVIDIA-NeMo:mainfrom
edjson:feat/device-mesh-consolidation

Conversation

@edjson
Copy link
Copy Markdown

@edjson edjson commented Apr 14, 2026

What does this PR do ?

Removes separate moe_mesh parameter form NeMoAutoModel so users only need to pass in device_mesh to the NeMoAutoModel class.

Changelog

  • Add specific line by line info of high level changes in this PR.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

@copy-pr-bot
Copy link
Copy Markdown

copy-pr-bot bot commented Apr 14, 2026

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@edjson edjson marked this pull request as draft April 14, 2026 07:02
@edjson
Copy link
Copy Markdown
Author

edjson commented Apr 14, 2026

Hello @adil-a, I am just opening up this draft to talk more about the design changes. My current plans are to:

  1. Remove the moe_mesh parameter from auto_model.py on line 468
  2. Delete device_mesh.py
  3. Update all the device_mesh.py imports to mesh_utils.py

Before I begin, should I initialize moe_mesh in MeshContext.__post_init__, or make moe_mesh from calling it in from_pretrained?

edjson added 2 commits April 19, 2026 21:25
Signed-off-by: Edison <edisonggacc@gmail.com>
Signed-off-by: Edison <edisonggacc@gmail.com>
@edjson edjson force-pushed the feat/device-mesh-consolidation branch from 1108a09 to a30b7f0 Compare April 20, 2026 04:26
@edjson edjson changed the title draft: Remove separate moe_mesh references refactor: Remove separate moe_mesh references Apr 20, 2026
@edjson edjson marked this pull request as ready for review April 20, 2026 04:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Remove separate moe_mesh references after https://github.com/NVIDIA-NeMo/Automodel/pull/1684

2 participants