feat: Add TE rope fusion for custom MoE models #897
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hemildesai
requested review from
HuiyingLi,
adil-a and
akoumpa
as code owners
Contributor
Author
|
/ok to test f3e1ce1 |
Signed-off-by: Hemil Desai <[email protected]>
hemildesai
force-pushed
the
hemil/rope-fusion
branch
from
f3e1ce1 to
5b76e59
Compare
Contributor
Author
|
/ok to test 5b76e59 |
Signed-off-by: Hemil Desai <[email protected]>
Contributor
|
/ok to test 8100a0d |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Can give up to 10% speedup
Closes #606
Qwen - https://wandb.ai/Nemo-automodel/qwen3_moe-cp-pp-grid
Moonlight - https://wandb.ai/Nemo-automodel/moonlight-automodel-cp-pp-grid