-
Notifications
You must be signed in to change notification settings - Fork 210
remove cosmos-curate ref #1334
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
remove cosmos-curate ref #1334
Conversation
Signed-off-by: Ao Tang <[email protected]>
|
/ok to test 2fd8efd |
Greptile OverviewGreptile SummaryThis PR removes an outdated reference to "cosmos-curate" from the Key Changes:
Additional Finding: Confidence Score: 4/5
Important Files ChangedFile Analysis
Sequence DiagramsequenceDiagram
participant Dev as Developer
participant Doc as Documentation (base.py)
participant Code as ModelInterface
Dev->>Doc: Remove "cosmos-curate" reference
Note over Doc: Line 32: Remove outdated sentence
Doc-->>Code: Updated docstring
Note over Code: No functional changes
Note over Code: model_id_names behavior unchanged
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Additional Comments (1)
-
nemo_curator/models/base.py, line 29-37 (link)style: Check if the reference to "Cosmos Curate" in
api-design.md:20should also be removed for consistency across the codebase.Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!
1 file reviewed, 1 comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
1 file reviewed, 1 comment
| """Returns a list of model IDs associated with the model. | ||
| In cosmos-curate, each model has an ID associated with it. | ||
| This is often the huggingspace name for that model (e.g. Salesforce/instructblip-vicuna-13b). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"huggingspace" appears to be a typo and should be "Hugging Face" since the codebase uses huggingface-hub as a dependency and all model IDs reference the Hugging Face model hub (e.g., "openai/clip-vit-large-patch14").
| This is often the huggingspace name for that model (e.g. Salesforce/instructblip-vicuna-13b). | |
| This is often the Hugging Face name for that model (e.g. Salesforce/instructblip-vicuna-13b). |
Description
Usage
# Add snippet demonstrating usageChecklist