Skip to content

Conversation

@suiyoubi
Copy link
Contributor

Description

Usage

# Add snippet demonstrating usage

Checklist

  • I am familiar with the Contributing Guide.
  • New or Existing tests cover these changes.
  • The documentation is up to date with these changes.

@copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 19, 2025

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@suiyoubi
Copy link
Contributor Author

/ok to test 2fd8efd

@greptile-apps
Copy link
Contributor

greptile-apps bot commented Dec 19, 2025

Greptile Overview

Greptile Summary

This PR removes an outdated reference to "cosmos-curate" from the ModelInterface.model_id_names docstring in nemo_curator/models/base.py. This is a documentation cleanup change that removes legacy terminology.

Key Changes:

  • Removed one line mentioning "In cosmos-curate, each model has an ID associated with it." from the model_id_names property docstring at line 32
  • No functional code changes - this is purely a documentation update

Additional Finding:
During review, I discovered a pre-existing typo in the same docstring: "huggingspace" should be "Hugging Face" to match the actual dependency (huggingface-hub) and common terminology.

Confidence Score: 4/5

  • This PR is safe to merge with minimal risk - it's a simple documentation change
  • Score of 4/5 reflects that this is a straightforward documentation-only change with no functional impact. The only issue found is a pre-existing typo ("huggingspace" instead of "Hugging Face") that was already in the codebase before this PR. The removal of the "cosmos-curate" reference is appropriate and improves documentation clarity.
  • No files require special attention - this is a trivial documentation change

Important Files Changed

File Analysis

Filename Score Overview
nemo_curator/models/base.py 4/5 Removed outdated "cosmos-curate" reference from docstring; found typo "huggingspace" should be "Hugging Face"

Sequence Diagram

sequenceDiagram
    participant Dev as Developer
    participant Doc as Documentation (base.py)
    participant Code as ModelInterface

    Dev->>Doc: Remove "cosmos-curate" reference
    Note over Doc: Line 32: Remove outdated sentence
    Doc-->>Code: Updated docstring
    Note over Code: No functional changes
    Note over Code: model_id_names behavior unchanged
Loading

Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Additional Comments (1)

  1. nemo_curator/models/base.py, line 29-37 (link)

    style: Check if the reference to "Cosmos Curate" in api-design.md:20 should also be removed for consistency across the codebase.

    Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time!

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

@suiyoubi suiyoubi enabled auto-merge (squash) December 19, 2025 18:55
Copy link
Contributor

@greptile-apps greptile-apps bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

1 file reviewed, 1 comment

Edit Code Review Agent Settings | Greptile

"""Returns a list of model IDs associated with the model.
In cosmos-curate, each model has an ID associated with it.
This is often the huggingspace name for that model (e.g. Salesforce/instructblip-vicuna-13b).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"huggingspace" appears to be a typo and should be "Hugging Face" since the codebase uses huggingface-hub as a dependency and all model IDs reference the Hugging Face model hub (e.g., "openai/clip-vit-large-patch14").

Suggested change
This is often the huggingspace name for that model (e.g. Salesforce/instructblip-vicuna-13b).
This is often the Hugging Face name for that model (e.g. Salesforce/instructblip-vicuna-13b).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants