-
Notifications
You must be signed in to change notification settings - Fork 210
chore(beep boop 🤖): Bump uv.lock (main) (2026-01-05)
#1349
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
pablo-garay
wants to merge
11
commits into
main
Choose a base branch
from
bump-dependencies-2026-01-05-main
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
11 commits
Select commit
Hold shift + click to select a range
face2d9
chore(beep boop 🤖): Bump `uv.lock` (main) (2026-01-05)
pablo-garay c309782
Merge branch 'main' into bump-dependencies-2026-01-05-main
praateekmahajan 02c310b
Add uv.lock to condition of triggering cicd tests
thomasdhc d051643
update pin for sklearn + fix broken backend integration test
praateekmahajan a1cb7e9
greptiles suggestion on version parsing
praateekmahajan 19877d7
Merge branch 'main' of github.com:NVIDIA/NeMo-Curator into bump-depen…
praateekmahajan 97a7e09
reverse conditional of ray version
praateekmahajan fbf1b55
empty commit
praateekmahajan bb2daef
add verbose logging in pytest; DO NOT MERGE
praateekmahajan 798d9af
empty commit 2
praateekmahajan fc70348
pythonfaulthandler?
praateekmahajan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -192,6 +192,12 @@ def test_ray_data_execution_plan(self): | |||||
| """Test that Ray Data creates the expected execution plan with correct stage organization.""" | ||||||
| if self.backend_cls != RayDataExecutor: | ||||||
| pytest.skip("Execution plan test only applies to RayDataExecutor") | ||||||
| from packaging import version | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. move import to top of file with other imports (line 24)
Suggested change
Then add at line 24 after other imports: Note: If this suggestion doesn't match your team's coding style, reply to this and let me know. I'll remember it for next time! |
||||||
|
|
||||||
| if version.parse(ray.__version__) >= version.parse("2.53.0"): | ||||||
| streaming_partitioning_stage = "StreamingRepartition[num_rows_per_block=1]" | ||||||
| else: | ||||||
| streaming_partitioning_stage = "StreamingRepartition" | ||||||
|
|
||||||
| # Look for execution plan in logs with multiple possible patterns | ||||||
| matches = re.findall(r"Execution plan of Dataset.*?:\s*(.+)", self.all_logs, re.MULTILINE) | ||||||
|
|
@@ -205,10 +211,10 @@ def test_ray_data_execution_plan(self): | |||||
| expected_stages = [ | ||||||
| "InputDataBuffer[Input]", | ||||||
| "TaskPoolMapOperator[MapBatches(FilePartitioningStageTask)]", | ||||||
| "TaskPoolMapOperator[StreamingRepartition]", | ||||||
| f"TaskPoolMapOperator[{streaming_partitioning_stage}]", | ||||||
| "ActorPoolMapOperator[MapBatches(JsonlReaderStageTask)->MapBatches(AddLengthStageActor)]", | ||||||
| "ActorPoolMapOperator[MapBatches(SplitIntoRowsStageActor)]", | ||||||
| "TaskPoolMapOperator[StreamingRepartition]", | ||||||
| f"TaskPoolMapOperator[{streaming_partitioning_stage}]", | ||||||
| "ActorPoolMapOperator[MapBatches(AddLengthStageActor)]", | ||||||
| "ActorPoolMapOperator[MapBatches(StageWithSetupActor)]", | ||||||
| "TaskPoolMapOperator[MapBatches(JsonlWriterTask)]", | ||||||
|
|
||||||
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This change originates from commit bb2daef with message "add verbose logging in pytest; DO NOT MERGE". The
-vv -sflags increase pytest verbosity and disable output capture, which may significantly increase CI log volume. Verify this debugging configuration should be merged to main. Should these verbose pytest flags be included in main, or were they intended for debugging only?