Skip to content

Make vLLM Default for Semantic Workflow + Update Embedding Benchmark + Upate Semantic Tutorials to support cloud #1375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
praateekmahajan wants to merge 28 commits into
base: main
Choose a base branch
from
Open

Make vLLM Default for Semantic Workflow + Update Embedding Benchmark + Upate Semantic Tutorials to support cloud #1375

praateekmahajan wants to merge 28 commits into from

Conversation

@praateekmahajan
Copy link
Contributor

@praateekmahajan praateekmahajan commented Jan 15, 2026

Description

  1. Makes vLLM default in TextSemanticWorkflow (breaking change)
  2. Update Semantic Tutorial to work with new workflow and make it support cloud
  3. Update Embedding Benchmarks

Usage

# Add snippet demonstrating usage

Checklist

  • I am familiar with the Contributing Guide.
  • New or Existing tests cover these changes.
  • The documentation is up to date with these changes.

praateekmahajan and others added 24 commits December 30, 2025 16:19
@praateekmahajan
..
c06c705 
Signed-off-by: Praateek <[email protected]>
@praateekmahajan
failing tests
d77ef3c 
Signed-off-by: Praateek <[email protected]>
@praateekmahajan
pin sklearn to < 1.8
7a318d3 
Signed-off-by: Praateek <[email protected]>
@ayushdg
Merge branch 'main' into praateek/vllm-embeddings
2894bdb
@praateekmahajan
merge main
f709307 
Signed-off-by: Praateek <[email protected]>
@praateekmahajan
Merge branch 'praateek/vllm-embeddings' of github.com:praateekmahajan…
da477e9 
…/NeMo-Curator into praateek/vllm-embeddings

Signed-off-by: Praateek <[email protected]>
@praateekmahajan
Merge branch 'main' of github.com:NVIDIA/NeMo-Curator into praateek/v…
03f9399 
…llm-embeddings

Signed-off-by: Praateek <[email protected]>
@praateekmahajan
pr reviews
ec63c6f 
Signed-off-by: Praateek <[email protected]>
@praateekmahajan
trying ray 2.52
7a9a282 
Signed-off-by: Praateek <[email protected]>
@praateekmahajan
f401 import vllm in test
4e3303c 
Signed-off-by: Praateek <[email protected]>
@praateekmahajan
Merge branch 'main' of github.com:NVIDIA/NeMo-Curator into praateek/v…
65c7c9c 
…llm-embeddings

Signed-off-by: Praateek <[email protected]>
@praateekmahajan
move sentence transformers to text_cpi
559f568 
Signed-off-by: Praateek <[email protected]>
@praateekmahajan
move imports around for gpu safety
eda934a 
Signed-off-by: Praateek <[email protected]>
@praateekmahajan
move fixutre inside
4c47bfc 
Signed-off-by: Praateek <[email protected]>
@praateekmahajan
double quote st
a1fe5c3 
Signed-off-by: Praateek <[email protected]>
@praateekmahajan
move fixture out
9eb824c 
Signed-off-by: Praateek <[email protected]>
@praateekmahajan
greptile comments
8a67c40 
Signed-off-by: Praateek <[email protected]>
@praateekmahajan
have teardown module in qwen_lm
11d0ebe 
Signed-off-by: Praateek <[email protected]>
@sarahyurick
Merge branch 'main' into praateek/vllm-embeddings
bcc51ad
@praateekmahajan
remove mock
069e1ba 
Signed-off-by: Praateek <[email protected]>
@praateekmahajan
Merge branch 'praateek/vllm-embeddings' of github.com:praateekmahajan…
e0a6967 
…/NeMo-Curator into praateek/vllm-embeddings

Signed-off-by: Praateek <[email protected]>
@praateekmahajan
update to ray 2.52.1
d4b99ee 
Signed-off-by: Praateek <[email protected]>
@praateekmahajan
fc
f04e096 
Signed-off-by: Praateek <[email protected]>
@praateekmahajan
Merge branch 'main' of github.com:NVIDIA/NeMo-Curator into praateek/m…
566d4fd 
…ake-vllm-default-semantic

Signed-off-by: Praateek <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@VibhuJawa VibhuJawa Awaiting requested review from VibhuJawa

@sarahyurick sarahyurick Awaiting requested review from sarahyurick

@ayushdg ayushdg Awaiting requested review from ayushdg

1 more reviewer

@greptile-apps greptile-apps[bot] greptile-apps[bot] left review comments

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@praateekmahajan @ayushdg @sarahyurick