Skip to content

fix(multinode-slurm): fix visibility of job component URLs #625

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
fgalko-oss merged 2 commits into from
Jan 12, 2026
Merged

fix(multinode-slurm): fix visibility of job component URLs #625

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
d920047
fix(multinode-slurm): fix visibility of job component URLs
AWarno Jan 12, 2026
db62819
style(add-nnodes): add back nnodes to avoid warning
AWarno Jan 12, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions packages/nemo-evaluator-launcher/src/nemo_evaluator_launcher/executors/slurm/executor.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -710,7 +710,7 @@ def _create_slurm_sbatch_script(

s += "# evaluation client\n"
s += "srun --mpi pmix --overlap "
s += "--nodes 1 --ntasks 1 " # Client always runs on single node
s += "--nodelist ${nodes_array[0]} --nodes 1 --ntasks 1 "
s += "--container-image {} ".format(eval_image)
evaluation_env_var_names = list(
cfg.execution.get("env_vars", {}).get("evaluation", {})
Expand Down Expand Up @@ -835,7 +835,7 @@ def _generate_auto_export_section(

s += " # export\n"
s += " srun --mpi pmix --overlap "
s += "--nodes 1 --ntasks 1 " # Client always runs on single node
s += "--nodelist ${nodes_array[0]} --nodes 1 --ntasks 1 "
s += "--container-image {} ".format(export_image)
if export_env:
s += "--container-env {} ".format(",".join(export_env))
Expand Down Expand Up @@ -1577,7 +1577,7 @@ def _generate_haproxy_srun_command(cfg, remote_task_subdir):
s += "done\n"
s += "\n"
s += "srun --mpi pmix --overlap "
s += "--nodes 1 --ntasks 1 "
s += "--nodelist ${nodes_array[0]} --nodes 1 --ntasks 1 "
s += f"--container-image {cfg.execution.get('proxy', {}).get('image', 'haproxy:latest')} "
s += f"--container-mounts {remote_task_subdir}/proxy.cfg:/usr/local/etc/haproxy/haproxy.cfg:ro "
s += f"--output {remote_task_subdir}/logs/proxy-%A.log "
Expand Down