Closed
Conversation
Split task query strings on the first dot only (split(".", 1)) so that
task names containing dots (e.g. mteb.Touche2020Retrieval.v3) are handled
correctly instead of raising an error.
Replace dots with hyphens in Lepton endpoint/job names for RFC 1123
compliance, instead of dropping everything before the last dot.
Remove the restriction that rejected queries with more than one dot
character.
Signed-off-by: Adam Rajfer <arajfer@nvidia.com>
Contributor
Author
|
/ok to test 12b53f5 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split task query strings on the first dot only (split(".", 1)) so that task names containing dots (e.g. mteb.Touche2020Retrieval.v3) are handled correctly instead of raising an error.
Replace dots with hyphens in Lepton endpoint/job names for RFC 1123 compliance, instead of dropping everything before the last dot.
Remove the restriction that rejected queries with more than one dot character.