Add max-model-len param for vLLM #502
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Onur Yilmaz <[email protected]>
|
/ok to test 6ffc9b3 |
athitten
reviewed
Nov 4, 2025
| cpu_offload_gb: float = 0, | ||
| enforce_eager: bool = False, | ||
| max_seq_len_to_capture: int = 8192, | ||
| max_model_len: int = 8192, |
There was a problem hiding this comment.
Thank you @oyilmaz-nvidia . For my understanding, why is this param needed now ? Is it new introduced by vLLM
There was a problem hiding this comment.
We really didn't need to set the parameter up until now but some of the large models like llama 70B might need some tuning to fit model into the GPUs. And CI is giving error now to fit this model (it was working before but with the newer versions of vllm, we might need to tune it).
athitten
approved these changes
Nov 4, 2025
Signed-off-by: Onur Yilmaz <[email protected]>
|
/ok to test 4d16afa |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.