fix(nvarc): bound and reap interpreter processes - #3054
Open
ananthsub wants to merge 1 commit into
Open
Conversation
Contributor
Author
|
fyi @esarafian |
cmunley1
reviewed
Sep 3, 2026
| input_json=json.dumps(input_grid), | ||
| ) | ||
|
|
||
| proc = await asyncio.create_subprocess_exec( |
Contributor
There was a problem hiding this comment.
should this stay inside the try?
If spawning raises OSError (for example, process or file-descriptor exhaustion), verification now returns a 500 instead of the previous None
Prevent timed-out or cancelled inductive verification children from surviving while limiting per-worker interpreter fanout. Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
ananthsub
force-pushed
the
ananthsub/fix-nvarc-process-lifecycle
branch
from
September 3, 2026 19:28
b5141b0 to
b281ae0
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
python_max_concurrencysettingCorrectness and reliability
The configured execution timeout starts after semaphore admission, so queueing does not consume a submission's runtime budget. Existing
Noneprediction and zero-reward behavior is preserved for execution failures. This change makes no throughput improvement claim; admission control intentionally trades queue latency for bounded resource use.Validation
uv run --extra dev pytest resources_servers/nvarc/tests/test_app.py -q— 43 passedCloses #3029