fix(serving): bound validation error logging - #3056
Open
ananthsub wants to merge 1 commit into
Open
Conversation
Prevent malformed large requests from creating full-body formatting and logging amplification while preserving FastAPI's 422 response contract. Signed-off-by: Ananth Subramaniam <ansubramania@nvidia.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
inputvaluesCorrectness and reliability
The request has already crossed FastAPI's validation boundary; this change only alters diagnostics. Empty, JSON, non-JSON, control-character, unavailable-body, and multi-megabyte inputs are covered. Logged prefixes are escaped so request-controlled newlines and nulls cannot inject raw control characters into logs.
Validation
uv run --extra dev pytest tests/unit_tests/test_server_utils.py -q— 33 passedFocused benchmark
Median handler formatting time and traced peak allocation, comparing the previous two full
json.dumps(..., indent=4)calls with the bounded logger:The tiny-body path is effectively unchanged; large-body CPU and allocation no longer scale with body size.
Closes #3007