Skip to content

refactor(docker): Dockerfile configurations and enhance environment variable management#4288

Open
balasaajay wants to merge 4 commits into
NVIDIA-NeMo:mainfrom
balasaajay:github-4266
Open

refactor(docker): Dockerfile configurations and enhance environment variable management#4288
balasaajay wants to merge 4 commits into
NVIDIA-NeMo:mainfrom
balasaajay:github-4266

Conversation

@balasaajay

@balasaajay balasaajay commented Jun 10, 2026

Copy link
Copy Markdown
Contributor

What does this PR do ?

attempting to fix - #4266

  • Consolidated environment variable definitions in Dockerfile.ci for improved readability.
  • Updated Dockerfile.fw_base to set default VLLM_VERSION and reorganized the build process for clarity.
  • Refactored Dockerfile.fw_final to normalize COPY commands and streamline repository cloning and commit updates.
  • Enhanced overall structure and maintainability of Dockerfiles across the project.

Changelog

  • Add specific line by line info of high level changes in this PR.

GitHub Actions CI

See the CI section in the Contributing doc for how to trigger the CI. A Nvidia developer will need to approve and trigger the CI for external contributors.

Before your PR is "Ready for review"

Pre checks:

  • Make sure you read and followed Contributor guidelines
  • Did you write any new necessary tests?
  • Did you add or update any necessary documentation?
  • Does the PR affect components that are optional to install? (Ex: Numba, Pynini, Apex etc)
    • Reviewer: Does the PR have correct import guards for all optional libraries?

If you haven't finished some of the above items you can still open "Draft" PR.

Additional Information

  • Related to # (issue)

@balasaajay balasaajay requested a review from a team as a code owner June 10, 2026 19:01
@copy-pr-bot

copy-pr-bot Bot commented Jun 10, 2026

Copy link
Copy Markdown

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@balasaajay
refactor(docker): streamline Dockerfile configurations and enhance en…
a742dd8 
…vironment variable management

- Consolidated environment variable definitions in Dockerfile.ci for improved readability.
- Updated Dockerfile.fw_base to set default VLLM_VERSION and reorganized the build process for clarity.
- Refactored Dockerfile.fw_final to normalize COPY commands and streamline repository cloning and commit updates.
- Enhanced overall structure and maintainability of Dockerfiles across the project.

Signed-off-by: Ajay Balasa <abalasa@nvidia.com>
@yaoyu-33 yaoyu-33 added area:build Dependencies, packaging, images, and environment setup bug Something isn't working needs-review PR is ready for code review and waiting on a reviewer labels Jun 10, 2026
@balasaajay

balasaajay commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test a742dd8

@balasaajay
Merge branch 'main' of https://github.com/NVIDIA-NeMo/Megatron-Bridge …
f95b1ce 
…into github-4266

Signed-off-by: Ajay Balasa <abalasa@nvidia.com>

# Conflicts:
#	docker/Dockerfile.fw_final
@balasaajay
revert some changes as they are needed for optimizing docker image bu…
1c84d9e 
…ild.

Signed-off-by: Ajay Balasa <abalasa@nvidia.com>
@balasaajay
Revert dockerfile final
1ea8136 
Signed-off-by: Ajay Balasa <abalasa@nvidia.com>
@balasaajay

balasaajay commented Jun 11, 2026

Copy link
Copy Markdown
Contributor Author

/ok to test 1ea8136

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

area:build Dependencies, packaging, images, and environment setup bug Something isn't working needs-review PR is ready for code review and waiting on a reviewer

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@balasaajay @yaoyu-33