[test] fix: repair CP packed SFT functional setup#4374
Merged
Conversation
Signed-off-by: yaoyu-33 <yaoyu.094@gmail.com>
Contributor
Author
|
/ok to test dc094b0 |
Contributor
ReviewLGTM. The change correctly splits the test into a two-phase pretrain → finetune flow:
Imports, config fields, and function signatures all check out. Suggested test cases: No perf tests impacted. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
checkpoint.pretrained_checkpointfor the SFT run.checkpoint.load = Noneso this exercises the intended finetune-from-pretrained path instead of trying to resume.Validation
git diff --check HEAD~1..HEADuv tool run ruff check tests/functional_tests/test_groups/training/test_seqpacking_cp_example.pyuv tool run ruff format --check tests/functional_tests/test_groups/training/test_seqpacking_cp_example.pyuv run --no-sync python -m py_compile tests/functional_tests/test_groups/training/test_seqpacking_cp_example.pyuv run --no-sync pre-commit run --files tests/functional_tests/test_groups/training/test_seqpacking_cp_example.pyExact GPU functional execution is left to CI.