Skip to content

[training] fix: prevent crash on side-threads #4375

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
tdene wants to merge 1 commit into
base: main
Choose a base branch
from
+8 −3
Open

[training] fix: prevent crash on side-threads #4375

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
11 changes: 8 additions & 3 deletions src/megatron/bridge/training/utils/sig_utils.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,6 +13,7 @@
# limitations under the License.

import signal
import threading
from typing import Any, Optional

import torch
Expand Down Expand Up @@ -105,6 +106,7 @@ def __init__(self, sig: int = signal.SIGTERM) -> None:
self._signal_received = False
self.released = False
self.original_handler = None
self._installed = False

def signals_received(self) -> list[bool]:
"""Check if any rank in the default group received the signal.
Expand All @@ -121,14 +123,16 @@ def signals_received(self) -> list[bool]:
def __enter__(self) -> "DistributedSignalHandler":
self._signal_received = False
self.released = False
self._installed = False
self.original_handler = signal.getsignal(self.sig)

def handler(signum: int, frame: Optional[Any]) -> None:
print_rank_0(f"Received signal {signum}, initiating graceful stop")
self._signal_received = True

signal.signal(self.sig, handler)
print_rank_0(f"Signal handler installed for {self.sig}")
if threading.current_thread() is threading.main_thread():
signal.signal(self.sig, handler)
self._installed = True

return self

Expand All @@ -145,6 +149,7 @@ def release(self) -> bool:
if self.released:
return False

signal.signal(self.sig, self.original_handler)
if self._installed:
signal.signal(self.sig, self.original_handler)
self.released = True
return True
Loading